-
Notifications
You must be signed in to change notification settings - Fork 26
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Reversible vtxo in async payment #311
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Cli fix config
May be worth to lay down the ground work of key path spending for cooperative cases? We may not need to migrate right now, but at least figuring out the abstraction of needs some more work in the future, better now |
altafan
reviewed
Sep 17, 2024
altafan
reviewed
Sep 18, 2024
altafan
reviewed
Sep 18, 2024
server/internal/infrastructure/tx-builder/covenant/builder_test.go
Outdated
Show resolved
Hide resolved
altafan
reviewed
Sep 18, 2024
altafan
approved these changes
Sep 19, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds the necessary abstraction to process different types of VTXOs. It allows adding the
ReversibleVtxoScript
type used as output of async payments.Vtxo script type
User && ASP
) and 1 exit closure (A after t
). It may contain others closures implementing specific use cases.common.VtxoScript
abstracts the taproot complexity of vtxo script.tr(_,{ and(pk(USER), pk(ASP)), and(older(T), pk(USER)) })
tr(_,{ { and(pk(SENDER), pk(ASP)), and(older(T), pk(SENDER)) }, { and(pk(RECEIVER), pk(ASP) } })
TL;DR
VtxoScript
interfaceVtxoScript
to craft vtxo tree transactionsdescriptor
instead of pubkey while registering inputssigningPubKey
when spending a VTXOdescriptor
instead of offchain address while registering outputsVtxo.Pubkey
byVtxo.Descriptor
PS: This PR does not add the necessary change to support the "Reverse" UX in the SDK even if it's technically possible today for the sender to spend (via reverse forfeit leaf) an async payment VTXO. It may need extra work to keep track of the reversible VTXOs and coin-select them.
@altafan @tiero @sekulicd @bordalix please review