Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(argo-rollouts): Change controller deployment strategy to rollinUpdate #2572

Closed
wants to merge 1 commit into from

Conversation

ilyastoliar
Copy link

@ilyastoliar ilyastoliar commented Mar 3, 2024

Signed-off-by: Ilya Stoliar [email protected]

Change controller deployment strategy to rollingUpdate due to chore: change controller's deploy strategy to RollingUpdate due to leader election #3334
argoproj/argo-rollouts#3334

Checklist:

  • I have bumped the chart version according to versioning
  • I have updated the documentation according to documentation
  • I have updated the chart changelog with all the changes that come with this pull request according to changelog.
  • Any new values are backwards compatible and/or have sensible default.
  • I have signed off all my commits as required by DCO.
  • My build is green (troubleshooting builds).

@jmeridth
Copy link
Member

jmeridth commented Mar 3, 2024

Thank you for your contribution. Unfortunately, argoproj/argo-rollouts#3334 is merged but not released, so we can't apply it to the helm chart yet. There was a release after it was merged but it did not include the change.

Also #2412 is the more configurable approach.

Copy link
Member

@jmeridth jmeridth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for your contribution but I believe #2412 is the better approach and we're still waiting for upstream to release the change also.

@yu-croco
Copy link
Collaborator

yu-croco commented Mar 3, 2024

Hi @ilyastoliar , thank you for your PR. I agree with @jmeridth .

@mkilchhofer
Copy link
Member

Closing this in favor of #2412

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants