Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUGFIX] Prevent index error with empty values #5787

Merged

Conversation

frascuchon
Copy link
Member

Description

This PR fixes error when indexing records with missing values for chat fields. Noticed in this discord thread

Type of change

  • Bug fix (non-breaking change which fixes an issue)

How Has This Been Tested

Checklist

  • I added relevant documentation
  • I followed the style guidelines of this project
  • I did a self-review of my code
  • I made corresponding changes to the documentation
  • I confirm My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • I have added relevant notes to the CHANGELOG.md file (See https://keepachangelog.com/)

Copy link

codecov bot commented Jan 20, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 91.96%. Comparing base (6a00494) to head (0cc4de3).
Report is 1 commits behind head on develop.

Additional details and impacted files
@@           Coverage Diff            @@
##           develop    #5787   +/-   ##
========================================
  Coverage    91.95%   91.96%           
========================================
  Files          161      161           
  Lines         6927     6928    +1     
========================================
+ Hits          6370     6371    +1     
  Misses         557      557           
Flag Coverage Δ
argilla-server 91.96% <100.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@frascuchon frascuchon force-pushed the bugfixes/prevent-index-errors-with-missing-chat-fields branch from 6460413 to 0340feb Compare January 21, 2025 08:34
@frascuchon frascuchon merged commit c49305d into develop Jan 21, 2025
1 of 7 checks passed
@frascuchon frascuchon deleted the bugfixes/prevent-index-errors-with-missing-chat-fields branch January 21, 2025 10:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants