-
Notifications
You must be signed in to change notification settings - Fork 401
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[BUGFIX] Prevent index error with empty values #5787
Merged
frascuchon
merged 8 commits into
develop
from
bugfixes/prevent-index-errors-with-missing-chat-fields
Jan 21, 2025
Merged
[BUGFIX] Prevent index error with empty values #5787
frascuchon
merged 8 commits into
develop
from
bugfixes/prevent-index-errors-with-missing-chat-fields
Jan 21, 2025
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #5787 +/- ##
========================================
Coverage 91.95% 91.96%
========================================
Files 161 161
Lines 6927 6928 +1
========================================
+ Hits 6370 6371 +1
Misses 557 557
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
frascuchon
force-pushed
the
bugfixes/prevent-index-errors-with-missing-chat-fields
branch
from
January 21, 2025 08:34
6460413
to
0340feb
Compare
frascuchon
commented
Jan 21, 2025
davidberenstein1957
approved these changes
Jan 21, 2025
frascuchon
deleted the
bugfixes/prevent-index-errors-with-missing-chat-fields
branch
January 21, 2025 10:38
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR fixes error when indexing records with missing values for chat fields. Noticed in this discord thread
Type of change
How Has This Been Tested
Checklist