Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FIX] [ENHANCEMENT] logging records in notebook without ipython #4988

Merged
merged 10 commits into from
Jun 13, 2024

Conversation

burtenshaw
Copy link
Contributor

This PR introduces these results in a notebook environment:

image

  • tqdm shows a status bar
  • non info level logging is printed with rich
  • DatasetRecords.log returns self not List[Record]
  • html repr of resources is dealt with as string not ipython HTML

Argilla Community Growers

Thanks for your contribution! As part of our Community Growers initiative 🌱, we're donating Justdiggit bunds in your name to reforest sub-Saharan Africa. To claim your Community Growers certificate, please contact David Berenstein in our Slack community or fill in this form https://tally.so/r/n9XrxK once your PR has been merged.

Pull Request Templates

Please go the the Preview tab and select the appropriate sub-template:

Generic Pull Request Template

Please include a summary of the changes and the related issue. Please also include relevant motivation and context. List any dependencies that are required for this change.

Closes #<issue_number>

Type of change

(Please delete options that are not relevant. Remember to title the PR according to the type of change)

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Refactor (change restructuring the codebase without changing functionality)
  • Improvement (change adding some improvement to an existing functionality)
  • Documentation update

How Has This Been Tested

(Please describe the tests that you ran to verify your changes. And ideally, reference tests)

  • Test A
  • Test B

Checklist

  • I added relevant documentation
  • follows the style guidelines of this project
  • I did a self-review of my code
  • I made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • I filled out the contributor form (see text above)
  • I have added relevant notes to the CHANGELOG.md file (See https://keepachangelog.com/)

@burtenshaw burtenshaw changed the base branch from develop to feat/v2.0.0 June 11, 2024 10:04
@burtenshaw burtenshaw requested a review from frascuchon June 11, 2024 10:04
Copy link

The URL of the deployed environment for this PR is https://argilla-quickstart-pr-4988-ki24f765kq-no.a.run.app

Copy link
Member

@frascuchon frascuchon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we should also remove refs to IPython in client.py

@burtenshaw burtenshaw linked an issue Jun 12, 2024 that may be closed by this pull request
@frascuchon frascuchon self-requested a review June 12, 2024 07:55
@frascuchon frascuchon self-requested a review June 12, 2024 10:20
Copy link

codecov bot commented Jun 12, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 60.90%. Comparing base (f4f0937) to head (6f25dca).
Report is 4 commits behind head on feat/v2.0.0.

Additional details and impacted files
@@               Coverage Diff               @@
##           feat/v2.0.0    #4988      +/-   ##
===============================================
- Coverage        60.92%   60.90%   -0.02%     
===============================================
  Files              329      329              
  Lines            17674    17674              
===============================================
- Hits             10767    10765       -2     
- Misses            6907     6909       +2     
Flag Coverage Δ
argilla 45.92% <ø> (-0.02%) ⬇️
argilla-server 91.32% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@burtenshaw burtenshaw merged commit 8e9f42b into feat/v2.0.0 Jun 13, 2024
23 of 26 checks passed
@burtenshaw burtenshaw deleted the feat/logging-records-in-notebook branch June 13, 2024 08:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BUG] ModuleNotFoundError: No module named 'IPython'
3 participants