-
Notifications
You must be signed in to change notification settings - Fork 401
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[FIX] [ENHANCEMENT] logging records in notebook without ipython #4988
Conversation
…t/logging-records-in-notebook
The URL of the deployed environment for this PR is https://argilla-quickstart-pr-4988-ki24f765kq-no.a.run.app |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think we should also remove refs to IPython in client.py
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## feat/v2.0.0 #4988 +/- ##
===============================================
- Coverage 60.92% 60.90% -0.02%
===============================================
Files 329 329
Lines 17674 17674
===============================================
- Hits 10767 10765 -2
- Misses 6907 6909 +2
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
This PR introduces these results in a notebook environment:
DatasetRecords.log
returns self notList[Record]
HTML
Argilla Community Growers
Thanks for your contribution! As part of our Community Growers initiative 🌱, we're donating Justdiggit bunds in your name to reforest sub-Saharan Africa. To claim your Community Growers certificate, please contact David Berenstein in our Slack community or fill in this form https://tally.so/r/n9XrxK once your PR has been merged.
Pull Request Templates
Please go the the
Preview
tab and select the appropriate sub-template:Generic Pull Request Template
Please include a summary of the changes and the related issue. Please also include relevant motivation and context. List any dependencies that are required for this change.
Closes #<issue_number>
Type of change
(Please delete options that are not relevant. Remember to title the PR according to the type of change)
How Has This Been Tested
(Please describe the tests that you ran to verify your changes. And ideally, reference
tests
)Checklist