feat: delete records #4980
Merged
feat: delete records #4980
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
for more information, see https://pre-commit.ci
Closed
Co-authored-by: David Berenstein <[email protected]>
Co-authored-by: David Berenstein <[email protected]>
frascuchon
reviewed
Jun 10, 2024
|
@sdiazlor there is a merge conflict. Can you try to resolve it please :) ? |
frascuchon
reviewed
Jun 12, 2024
| ```python | ||
| status_filter = rg.Query( | ||
| filter = rg.Filter(("status", "==", "pending")) |
There was a problem hiding this comment.
Since I'm seeing this and after the discussion this morning about task distribution. Does it make sense if we rename the current status to something like "response.status"? (not to handle on this PR, just a question)
cc @burtenshaw @davidberenstein1957 @dvsrepo
There was a problem hiding this comment.
I think I missed the task distribution meeting but what is the reasoning behind the raneme to the "response.status"?
There was a problem hiding this comment.
At some point, we'll introduce status at a record-level. So having a general status name can create some confusion later.
frascuchon
approved these changes
Jun 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Basic method to delete the records. Records are still ingested to be validated, but I don't think we need to allow data structures in this workflow.
Closes #4930
Type of change
(Please delete options that are not relevant. Remember to title the PR according to the type of change)
How Has This Been Tested
(Please describe the tests that you ran to verify your changes. And ideally, reference
tests)Checklist
CHANGELOG.mdfile (See https://keepachangelog.com/)