-
Notifications
You must be signed in to change notification settings - Fork 2.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(sbom): keep internal uuid to identify components #7550
base: main
Are you sure you want to change the base?
Conversation
[skip ci] Signed-off-by: knqyf263 <[email protected]>
@DmitriyLewen @afdesk I'm not confident about this idea and would like to get thoughts before proceeding with implementation. |
Just make sure I got you right:
is this right? The solution looks good, and “on paper” it should work. |
Right. Other advantages are that types, properties etc. can also use the values of the original component. |
I think this is good solution. |
This PR is stale because it has been labeled with inactivity. |
This PR is stale because it has been labeled with inactivity. |
Description
There is no guarantee that this approach will reliably identify identical components. In the current implementation, it is possible for multiple components to have the same name and type.
To prevent this, I used BOM-Ref in CycloneDX using the BOM-Ref, but it does not work in SPDX, and furthermore, the BOM-Ref is optional and may not exist.
Currently, intermediate BOMs are used internally to abstract multiple SBOM implementations, and each component is assigned a UUID. This ensures that the same component can be reused.
Related PRs
Checklist