Fix pr workflow #114
Merged
Fix pr workflow #114
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
iofq
force-pushed
the
fix_pr_workflow
branch
from
1ef56e5 to
a3fcdd5
Compare
|
CI will fail until #113 is merged first |
|
there was some automation when pushing to master, the feature/gh-action-pages branch would be updated... how would updating the page work after this change ? |
master behavior should be unchanged, this is to fix the deploy step from running on every pull request (even though it fails on pull requests anyway) |
neolynx
approved these changes
Nov 21, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #94
Does not run the deploy step unless for
masterbranch. Also updated actions to latest versions.