Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: uri encoding issues with user-agents in dart #1038

Merged
merged 6 commits into from
Feb 26, 2025
Merged

Conversation

ChiragAgg5k
Copy link
Member

@ChiragAgg5k ChiragAgg5k commented Feb 22, 2025

What does this PR do?

Adds encoding of User-Agent header in Flutter and Dart SDK.

Test Plan

before:
Screenshot 2025-02-22 at 12 05 35 PM

after:
Screenshot 2025-02-22 at 12 05 47 PM

Related PRs and Issues

Have you read the Contributing Guidelines on issues?

Yes.

@ItzNotABug
Copy link
Member

@ChiragAgg5k
Maybe a better call site change would be in the prepareRequest?
That's the function which finalises the headers right before triggering a request. wdyt?

Also not sure if Flutter is also affected here...

Copy link
Member

@ItzNotABug ItzNotABug left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Assuming there are no controllers on backend that manage the custom headers added by user, this seems OK.

@christyjacob4 christyjacob4 merged commit 47be76e into master Feb 26, 2025
35 checks passed
@christyjacob4 christyjacob4 deleted the pla-2547 branch February 26, 2025 06:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants