Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: dotnet & dart models #1033

Merged
merged 2 commits into from
Jan 29, 2025
Merged

fix: dotnet & dart models #1033

merged 2 commits into from
Jan 29, 2025

Conversation

loks0n
Copy link
Member

@loks0n loks0n commented Jan 29, 2025

  • fix(dotnet): models formatting
  • fix(dart): models empty sub_schema array scenario

loks0n
loks0n commented Jan 29, 2025
View reviewed changes
templates/dart/lib/src/models/model.dart.twig
@@ -33,7 +34,7 @@ class {{ definition.name | caseUcfirst | overrideIdentifier }} implements Model
{%- endif -%}
{%- else -%}
{%- if property.type == 'array' -%}
List<{{ property.items.type | caseUcfirst }}>.from(map['{{property.name | escapeDollarSign }}']?.map((x) => x{% if property.items.type == "string" %}.toString(){% endif %}) ?? [])
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not sure where this property.items.type property came from, it's empty.

@abnegate abnegate merged commit f0d2ea2 into master Jan 29, 2025
35 checks passed
@abnegate abnegate deleted the fix-dotnet-and-dart-formatting branch January 29, 2025 12:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@abnegate abnegate abnegate approved these changes

@ChiragAgg5k ChiragAgg5k ChiragAgg5k approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@loks0n @abnegate @ChiragAgg5k