-
Notifications
You must be signed in to change notification settings - Fork 176
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implement SDK Method Multiplexing #1014
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There's a lot of nesting in the getMethods
function, let's try to negate some cases and have early continues/returns to reduce the nesting
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Let's test and make sure all looks okay:
- Push existing 1.6.x SDKs to aw-tests
- Use this branch in an Appwrite branch off 1.6.x
- Generate SDKs and push to aw-tests
- Check there's no diff
- Use this branch in bulk API branch
- Generate SDKs and push to aw-tests
- Check multiplexed methods look as expected
What does this PR do?
This PR implements route multiplexing for supporting multiple methods being created from one API.
Have you read the Contributing Guidelines on issues?
Yes