Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement SDK Method Multiplexing #1014

Merged
merged 10 commits into from
Feb 4, 2025
Merged

Implement SDK Method Multiplexing #1014

merged 10 commits into from
Feb 4, 2025

Conversation

PineappleIOnic
Copy link
Contributor

What does this PR do?

This PR implements route multiplexing for supporting multiple methods being created from one API.

Have you read the Contributing Guidelines on issues?

Yes

Copy link
Member

@abnegate abnegate left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There's a lot of nesting in the getMethods function, let's try to negate some cases and have early continues/returns to reduce the nesting

Copy link
Member

@abnegate abnegate left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's test and make sure all looks okay:

  • Push existing 1.6.x SDKs to aw-tests
  • Use this branch in an Appwrite branch off 1.6.x
  • Generate SDKs and push to aw-tests
  • Check there's no diff
  • Use this branch in bulk API branch
  • Generate SDKs and push to aw-tests
  • Check multiplexed methods look as expected

@abnegate abnegate merged commit d288013 into master Feb 4, 2025
35 checks passed
@abnegate abnegate deleted the feat-route-muliplexing branch February 4, 2025 12:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants