RegEx Lookup and Improved RegEx #412
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
neha-viswanathan
force-pushed
the
cli-test-retry-timeout
branch
from
5403f90 to
d8fa9bc
Compare
generalhenry
suggested changes
Nov 3, 2016
| service-remove: ([a-z]+) | ||
| stack-create: ([a-z0-9]){64} | ||
| stack-list: NAME\s+ID\s+STATE\s*-+\s*\n+([a-z0-9A-Z\s]*){1,} | ||
| stack-stop: ([a-z0-9]){64} |
There was a problem hiding this comment.
Instead of [stack-create, stack-stop, stack-restart] it should be just a single stack-id
The same for service-id
generalhenry
suggested changes
Nov 3, 2016
| func TestCmds(t *testing.T) { | ||
| _, err := loadRegexLookup() |
There was a problem hiding this comment.
You never use the []*LookupSpec
| return | ||
| } | ||
|
|
||
| func loadRegexLookup() ([]*LookupSpec, error) { |
There was a problem hiding this comment.
So you can remove it here
| } | ||
|
|
||
| //Parse regex-lookup.yml using a map | ||
| func parseLookup(file string) (*LookupSpec, error) { |
generalhenry
approved these changes
Nov 3, 2016
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ref #387
Added
regex-lookup.ymlcontaining a dictionary of regular expressions used in the test runner. Also updated the regular expressions for better pattern matching.The earlier version of regular expressions was limited to matching the pattern of the first row of the output. The updated regex matches the pattern of the entire output that is returned.
To test:
go test github.com/appcelerator/amp/cmd/amp/cli