fix: security schemes keys to symbols #74
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
paulsturgess
reviewed
Sep 2, 2024
lib/apia/open_api/objects/path.rb
Outdated
| scope_prefix = @spec[:components][:securitySchemes][key][:"x-scope-prefix"] | ||
| auth_scheme = @spec[:components][:securitySchemes][key] |
There was a problem hiding this comment.
you could call symbolize_keys! or probably deep_symbolize_keys to forcibly convert the keys to symbols. In this loop is likely not the best place to do that. Perhaps when additions is constructed in the Specification initialize method. That way it would be standard for any code that accesses it.
There was a problem hiding this comment.
Thank you! on lookup it seems like that's a rails specific function so I've settled on using transform_keys 🙇
ikadix
force-pushed
the
fix_x_scope_prefix
branch
from
13f2e98 to
b75811c
Compare
ikadix
changed the title
paulsturgess
approved these changes
Sep 2, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Looks up the x-scope-security value by either a string or a symbol.
Would appreciate if there's a better way to do this look up or enforce the key type in the hash.
Edit
Rewritten to transform security scheme keys to symbols