[bugfix] show results in query history & revert #5848 #6436
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Are you sure you want to revert, or should we push forward? Did any following PRs assumed a |
Codecov Report
@@ Coverage Diff @@
## master #6436 +/- ##
=======================================
Coverage 56.25% 56.25%
=======================================
Files 519 519
Lines 23077 23077
Branches 2755 2755
=======================================
Hits 12982 12982
Misses 9686 9686
Partials 409 409
Continue to review full report at Codecov.
|
|
@mistercrunch @youngyjd |
youngyjd
changed the title
|
@graceguo-supercat @mistercrunch Commit message updated. @graceguo-supercat is a really good code reviewer. 👍 |
|
I'll let @graceguo-supercat chime in since I think she has more background on this. |
youngyjd
force-pushed
the
revert-5848
branch
2 times, most recently
from
b7ad78e to
899b034
Compare
youngyjd
added a commit
to lyft/incubator-superset
that referenced
this pull request
Jan 14, 2019
) * revert 848 * nit (cherry picked from commit b1dbd1c)
betodealmeida
pushed a commit
to lyft/incubator-superset
that referenced
this pull request
Jan 14, 2019
) * revert 848 * nit (cherry picked from commit b1dbd1c)
michellethomas
pushed a commit
that referenced
this pull request
Jan 14, 2019
betodealmeida
pushed a commit
to lyft/incubator-superset
that referenced
this pull request
Jan 17, 2019
) * revert 848 * nit (cherry picked from commit b1dbd1c)
betodealmeida
pushed a commit
to lyft/incubator-superset
that referenced
this pull request
Jan 24, 2019
) * revert 848 * nit (cherry picked from commit b1dbd1c)
betodealmeida
pushed a commit
to lyft/incubator-superset
that referenced
this pull request
Jan 30, 2019
) * revert 848 * nit (cherry picked from commit b1dbd1c)
betodealmeida
pushed a commit
to lyft/incubator-superset
that referenced
this pull request
Jan 30, 2019
) * revert 848 * nit (cherry picked from commit b1dbd1c)
betodealmeida
pushed a commit
to lyft/incubator-superset
that referenced
this pull request
Jan 30, 2019
) * revert 848 * nit (cherry picked from commit b1dbd1c)
betodealmeida
pushed a commit
to lyft/incubator-superset
that referenced
this pull request
Jan 30, 2019
) * revert 848 * nit (cherry picked from commit b1dbd1c)
betodealmeida
pushed a commit
to lyft/incubator-superset
that referenced
this pull request
Jan 30, 2019
) * revert 848 * nit (cherry picked from commit b1dbd1c)
betodealmeida
pushed a commit
to lyft/incubator-superset
that referenced
this pull request
Jan 30, 2019
) * revert 848 * nit (cherry picked from commit b1dbd1c)
mistercrunch
added
🏷️ bot
cccs-rc
pushed a commit
to CybercentreCanada/superset
that referenced
this pull request
Mar 6, 2024
) * revert 848 * nit (cherry picked from commit eb92282)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update:
Renderingis not necessary for query state. @graceguo-supercat made a really good point that it does not solve the inconsistency in 100% progress bar and running query state.The query lifecycle like
pending -> running -> success (or failed, stopped) ->fetchingwould be a simpler and better solution to solve it.I have tested
show query resultsin query history and verified it is not broken.