Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[bugfix] NoneType df has no attribute to_dict in IFrame #5965

Closed
wants to merge 1 commit into from

Conversation

pphszx
Copy link
Contributor

@pphszx pphszx commented Sep 24, 2018

iFrame doesn't work, and it seems to be introduced in #5753

Bug replication steps:

  1. Change visualization type to iFrame in any Explore view
  2. A exception is thrown
Traceback (most recent call last):
  File "/home/eric/Documents/github/incubator-superset/superset/views/core.py", line 1134, in generate_json
    payload = viz_obj.get_payload()
  File "/home/eric/Documents/github/incubator-superset/superset/viz.py", line 375, in get_payload
    payload['data'] = self.get_data(df)
  File "/home/eric/Documents/github/incubator-superset/superset/viz.py", line 489, in get_data
    return self.get_df().to_dict(orient='records')
AttributeError: 'NoneType' object has no attribute 'to_dict'

@pphszx pphszx closed this Oct 26, 2018
@pphszx pphszx deleted the fix_iframe_NoneType branch November 2, 2018 08:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant