Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Downgrade flask-appbuilder dependency #5127

Closed
wants to merge 1 commit into from
Closed

Downgrade flask-appbuilder dependency #5127

wants to merge 1 commit into from

Conversation

villebro
Copy link
Member

@villebro villebro commented Jun 2, 2018

It seems that flask-appbuilder-1.11 is more strict about sqlalchemy exceptions than 1.10. Should fix #5088

@codecov-io
Copy link

codecov-io commented Jun 2, 2018

Codecov Report

Merging #5127 into 0.25 will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##             0.25    #5127   +/-   ##
=======================================
  Coverage   77.04%   77.04%           
=======================================
  Files          44       44           
  Lines        8562     8562           
=======================================
  Hits         6597     6597           
  Misses       1965     1965

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3a3fc4c...179e907. Read the comment docs.

@xrmx
Copy link
Contributor

xrmx commented Jun 2, 2018

See #5122

@villebro
Copy link
Member Author

villebro commented Jun 3, 2018

Thanks, hadn't noticed that, would have saved me some effort finding the root cause of #5088. This PR is against the 0.25 branch, which I think we need to stabilize asap, but for the long term plan (master branch) it would probably be ideal to to stay on current versions of dependencies.

@villebro villebro closed this Jun 4, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants