-
Notifications
You must be signed in to change notification settings - Fork 14.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Moving some JS folders #4820
Moving some JS folders #4820
Conversation
Codecov Report
@@ Coverage Diff @@
## master #4820 +/- ##
==========================================
+ Coverage 72.36% 76.98% +4.61%
==========================================
Files 208 44 -164
Lines 15662 8498 -7164
Branches 1227 0 -1227
==========================================
- Hits 11334 6542 -4792
+ Misses 4325 1956 -2369
+ Partials 3 0 -3
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Awesome!
Ignore, I've seen the commit correcting this. There's a broken link in static/asset/src/visualizations/country_map.js: |
Fixed on master #4913 |
* Moving folders * Pointing to new locations
* Moving folders * Pointing to new locations
* Moving folders * Pointing to new locations
javascripts/ -> src/
visualizations/ -> src/visualizations/
I'll be careful to merge instead of squashing as git deals with merge conflicts better when
git mv
are in different commits than changes in the files somehow.