Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

more css fixes #182

Merged
merged 1 commit into from
Mar 16, 2016
Merged

more css fixes #182

merged 1 commit into from
Mar 16, 2016

Conversation

williaster
Copy link
Contributor

@mistercrunch
changes with this commit:

  • fixoverflow scroll bars on all dashboard charts
  • make dashboard chart control toggle interaction nicer (click to see instead of weird hover action)
  • make sure user-stylesheets are applied last (fixes Dashboard css is applied before static css #180)
  • remove ace css editor error/warning parsing (it assumes it's the only stylesheet so warnings are inaccurate)
  • make filters look nicer in dashboards
  • fix some linting errors on master

will work on the modal z-index separately, wanted to get these in.

…t control toggle interaction nicer. make sure user-stylesheets are applied last. remove ace css editor error/warning parsing. make filters look nicer in dashboards. fix some linting.
@@ -149,7 +149,8 @@ var Dashboard = function (dashboardData) {
editor.setTheme("ace/theme/crimson_editor");
editor.setOptions({
minLines: 16,
maxLines: Infinity
maxLines: Infinity,
useWorker: false
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this is the flag for not watching errors.

@williaster
Copy link
Contributor Author

hmm not sure what's up with the travis build, npm install failed.

@mistercrunch
Copy link
Member

Nice! LGTM

@williaster williaster merged commit 2aa0e0d into master Mar 16, 2016
@williaster williaster deleted the chris/modal-and-dashboard-css-fixes branch March 16, 2016 16:11
@mistercrunch mistercrunch added 🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 0.8.1 labels Feb 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 0.8.1
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Dashboard css is applied before static css
2 participants