Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Removes unused Hotkeys component #13408

Merged
merged 1 commit into from
Mar 3, 2021

Conversation

michael-s-molina
Copy link
Member

SUMMARY

Removes unused Hotkeys component

Hotkeys were removed in #12008 with the following comment from @rusackas:

Heya... I took those out. At least for me, most of them don't actually work, so I figured it wouldn't be missed.

We can certainly put it back in if it's a big deal, but I'd rather design/implement a more global keyboard shortcut helper, e.g. hover/click a global item, and all the bits of UI with keyboard shortcuts light up. For example, the Run button would get a little ctrl-r tooltip next to it.

Since the component wasn't being used I removed it.

TEST PLAN

1 - Execute all tests
2 - All tests should pass

ADDITIONAL INFORMATION

  • Has associated issue:
  • Changes UI
  • Requires DB Migration.
  • Confirm DB Migration upgrade and downgrade tested.
  • Introduces new feature or API
  • Removes existing feature or API

@codecov
Copy link

codecov bot commented Mar 2, 2021

Codecov Report

Merging #13408 (c087b0d) into master (f19a830) will decrease coverage by 3.22%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #13408      +/-   ##
==========================================
- Coverage   76.33%   73.10%   -3.23%     
==========================================
  Files         900      598     -302     
  Lines       45596    21132   -24464     
  Branches     5491     5489       -2     
==========================================
- Hits        34804    15448   -19356     
+ Misses      10648     5557    -5091     
+ Partials      144      127      -17     
Flag Coverage Δ
cypress 57.95% <ø> (-0.85%) ⬇️
hive ?
javascript 62.80% <ø> (+0.04%) ⬆️
mysql ?
postgres ?
presto ?
python ?
sqlite ?

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...erset-frontend/src/SqlLab/components/ResultSet.tsx 68.46% <0.00%> (-0.31%) ⬇️
superset/examples/flights.py
superset/models/helpers.py
superset/db_engine_specs/gsheets.py
superset/utils/url_map_converters.py
superset/css_templates/filters.py
superset/annotation_layers/commands/create.py
superset/dashboards/schemas.py
superset/views/schedules.py
superset/connectors/sqla/__init__.py
... and 352 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f19a830...885f231. Read the comment docs.

Copy link
Member

@rusackas rusackas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We have the technology to bring it back.

@rusackas rusackas merged commit 65cec18 into apache:master Mar 3, 2021
allanco91 pushed a commit to allanco91/superset that referenced this pull request May 21, 2021
@mistercrunch mistercrunch added 🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 1.2.0 labels Mar 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels size/M 🚢 1.2.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants