Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: remove SIP_34_ALERTS_UI from config #12127

Merged
merged 1 commit into from
Dec 18, 2020

Conversation

nytai
Copy link
Member

@nytai nytai commented Dec 18, 2020

SUMMARY

#12085 removed all usage of the flag, but left a reference in config.py. This PR removes it to avoid confusion.

BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF

  • N/A

TEST PLAN

  • Nothing should change

ADDITIONAL INFORMATION

  • Has associated issue:
  • Changes UI
  • Requires DB Migration.
  • Confirm DB Migration upgrade and downgrade tested.
  • Introduces new feature or API
  • Removes existing feature or API

@codecov-io
Copy link

codecov-io commented Dec 18, 2020

Codecov Report

Merging #12127 (ff61ee4) into master (8e625e0) will decrease coverage by 2.26%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #12127      +/-   ##
==========================================
- Coverage   65.61%   63.34%   -2.27%     
==========================================
  Files         972      972              
  Lines       48071    48086      +15     
  Branches     4758     4784      +26     
==========================================
- Hits        31542    30461    -1081     
- Misses      16374    17435    +1061     
- Partials      155      190      +35     
Flag Coverage Δ
cypress ?
javascript 61.96% <ø> (+0.01%) ⬆️
python 64.20% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
superset/config.py 90.51% <ø> (ø)
superset-frontend/src/SqlLab/App.jsx 0.00% <0.00%> (-100.00%) ⬇️
superset-frontend/src/explore/App.jsx 0.00% <0.00%> (-100.00%) ⬇️
superset-frontend/src/dashboard/App.jsx 0.00% <0.00%> (-100.00%) ⬇️
superset-frontend/src/setup/setupColors.js 0.00% <0.00%> (-100.00%) ⬇️
superset-frontend/src/chart/ChartContainer.jsx 0.00% <0.00%> (-100.00%) ⬇️
superset-frontend/src/explore/reducers/index.js 0.00% <0.00%> (-100.00%) ⬇️
...et-frontend/src/dashboard/containers/Dashboard.jsx 0.00% <0.00%> (-100.00%) ⬇️
...-frontend/src/visualizations/presets/MainPreset.js 0.00% <0.00%> (-100.00%) ⬇️
...tend/src/dashboard/containers/DashboardBuilder.jsx 0.00% <0.00%> (-100.00%) ⬇️
... and 115 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8e625e0...ff61ee4. Read the comment docs.

@nytai nytai merged commit 210fd25 into apache:master Dec 18, 2020
@nytai nytai deleted the tai/remove-ff-reference branch December 18, 2020 22:52
@mistercrunch mistercrunch added 🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 1.0.0 labels Mar 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels size/XS 🚢 1.0.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants