fix linting and remove css

apache · Sep 5, 2018 · 71065f9 · 71065f9
1 parent 82a1039
commit 71065f9
Show file tree

Hide file tree

Showing 3 changed files with 13 additions and 16 deletions.
diff --git a/superset/assets/src/visualizations/MapBox/MapBox.css b/superset/assets/src/visualizations/MapBox/MapBox.css
@@ -1,16 +1,3 @@
-.mapbox div.widget .slice_container {
-  cursor: grab;
-  cursor: -moz-grab;
-  cursor: -webkit-grab;
-  overflow: hidden;
-}
-
-.mapbox div.widget .slice_container:active {
-  cursor: grabbing;
-  cursor: -moz-grabbing;
-  cursor: -webkit-grabbing;
-}
-
 .mapbox .slice_container div {
   padding-top: 0px;
 }
diff --git a/superset/assets/src/visualizations/MapBox/MapBox.jsx b/superset/assets/src/visualizations/MapBox/MapBox.jsx
@@ -122,7 +122,7 @@ class MapBox extends React.Component {
           compositeOperation={'screen'}
           renderWhileDragging={renderWhileDragging}
           aggregatorName={aggregatorName}
-          lngLatAccessor={location => {
+          lngLatAccessor={(location) => {
             const coordinates = location.get('geometry').get('coordinates');
             return [coordinates.get(0), coordinates.get(1)];
           }}

diff --git a/superset/assets/src/visualizations/MapBox/ScatterPlotGlowOverlay.jsx b/superset/assets/src/visualizations/MapBox/ScatterPlotGlowOverlay.jsx
@@ -36,13 +36,23 @@ const contextTypes = {
 };
 
 class ScatterPlotGlowOverlay extends React.Component {
+  constructor(props) {
+    super(props);
+    this.setCanvasRef = this.setCanvasRef.bind(this);
+  }
+
   componentDidMount() {
     this.redraw();
   }
 
   componentDidUpdate() {
     this.redraw();
   }
+
+  setCanvasRef(element) {
+    this.canvas = element;
+  }
+
   drawText(ctx, pixel, options = {}) {
     const IS_DARK_THRESHOLD = 110;
     const { fontHeight = 0, label = '', radius = 0, rgb = [0, 0, 0], shadow = false } = options;
@@ -197,9 +207,9 @@ class ScatterPlotGlowOverlay extends React.Component {
         }
       }, this);
     }
-
     ctx.restore();
   }
+
   render() {
     let width = 0;
     let height = 0;
@@ -211,7 +221,7 @@ class ScatterPlotGlowOverlay extends React.Component {
     const pixelRatio = window.devicePixelRatio || 1;
     return (
       <canvas
-        ref={(c) => { this.canvas = c; }}
+        ref={this.setCanvasRef}
         width={width * pixelRatio}
         height={height * pixelRatio}
         style={{