Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[improve] RabbitMq connector options #8633

Open
wants to merge 2 commits into
base: dev
Choose a base branch
from

Conversation

akulabs8
Copy link
Contributor

@akulabs8 akulabs8 commented Feb 9, 2025

Purpose of this pull request

subtask of #8576

Check list

@@ -36,7 +36,7 @@
@Setter
@Getter
@AllArgsConstructor
public class RabbitmqConfig implements Serializable {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we should split Config and Options into two classes.
The Options class is used to record the parameters we can pass from the configuration file (external).
The RabbitmqConfig here is a class use to pass parameteres internal.

So, I think we need to split them. Please share your thoughts with me.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants