Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[improve] cdc options #8612

Open
wants to merge 6 commits into
base: dev
Choose a base branch
from
Open

[improve] cdc options #8612

wants to merge 6 commits into from

Conversation

liunaijie
Copy link
Member

Purpose of this pull request

Does this PR introduce any user-facing change?

How was this patch tested?

Check list

@Hisoka-X
Copy link
Member

Hisoka-X commented Feb 6, 2025

Please rebase from dev.

@liunaijie liunaijie force-pushed the improve/cdc_options branch from fd4683f to fddae11 Compare February 7, 2025 02:01
Hisoka-X
Hisoka-X reviewed Feb 7, 2025
View reviewed changes
Copy link
Member

@Hisoka-X Hisoka-X left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

cc @hailin0

Hisoka-X
Hisoka-X reviewed Feb 7, 2025
View reviewed changes
...r-cdc-base/src/main/java/org/apache/seatunnel/connectors/cdc/base/option/CdcBaseOptions.java
public class SourceOptions {
public class CdcBaseOptions implements CatalogOptions {

// todo
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

any detail?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I forgot to delete it; I will remove it now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Hisoka-X Hisoka-X Hisoka-X left review comments

At least 2 approving reviews are required to merge this pull request.

Assignees
No one assigned
Labels
api cdc connectors-v2
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@liunaijie @Hisoka-X