Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Fix][Engine-Server] close task when job finished to release resource. #8610

Closed
wants to merge 1 commit into from

Conversation

sohurdc
Copy link
Contributor

@sohurdc sohurdc commented Feb 5, 2025

Purpose of this pull request

close resource when job finished.
image
the class SeaTunnelChildFirstClassLoader refered by FileSystem$Cache which not close when job finished.

Does this PR introduce any user-facing change?

no

How was this patch tested?

no, i will add it later after reviewd.

Check list

@@ -145,4 +145,6 @@ default Optional<Serializer<AggregatedCommitInfoT>> getAggregatedCommitInfoSeria
default Optional<CatalogTable> getWriteCatalogTable() {
return Optional.empty();
}

default void close() {}
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We don't add close method before because Flink/Spark doesn't has close method too. If we add close method on seatunnel api. Flink/Spark can not invoke it for now.

@Hisoka-X
Copy link
Member

Hisoka-X commented Feb 6, 2025

@sohurdc
Copy link
Contributor Author

sohurdc commented Feb 6, 2025

It is enabled, but there are still memory leaks in FileSystem$CACHE and HiveConf. I still have the problem of off-heap memory leak. I can't find the reason. I suspect it is related to the FileSystem not being closed.

@Hisoka-X
Copy link
Member

Hisoka-X commented Feb 6, 2025

It is enabled, but there are still memory leaks in FileSystem$CACHE and HiveConf. I still have the problem of off-heap memory leak. I can't find the reason. I suspect it is related to the FileSystem not being closed.

Maybe you can provide your server log and heap dump file in new issue so we can help to loc the root problem.

@sohurdc
Copy link
Contributor Author

sohurdc commented Feb 10, 2025

see there, #8637.
this can be closed.

@Hisoka-X Hisoka-X closed this Feb 11, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants