[Fix][Plugin] Optimize the plugin discovery mechanism #8603
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
cc @hailin0 |
Hisoka-X
reviewed
Feb 6, 2025
...n-discovery/src/main/java/org/apache/seatunnel/plugin/discovery/AbstractPluginDiscovery.java
Show resolved
Hide resolved
...n-discovery/src/main/java/org/apache/seatunnel/plugin/discovery/AbstractPluginDiscovery.java
Show resolved
Hide resolved
...n-discovery/src/main/java/org/apache/seatunnel/plugin/discovery/AbstractPluginDiscovery.java
Outdated
Show resolved
Hide resolved
corgy-w
force-pushed
the
fix-jar-discover
branch
from
70eb6d1 to
1840fbe
Compare
3 tasks
Hisoka-X
reviewed
Feb 12, 2025
...n-discovery/src/main/java/org/apache/seatunnel/plugin/discovery/AbstractPluginDiscovery.java
Show resolved
Hide resolved
...n-discovery/src/main/java/org/apache/seatunnel/plugin/discovery/AbstractPluginDiscovery.java
Outdated
Show resolved
Hide resolved
|
@hailin0 PTAL |
Hisoka-X
previously approved these changes
Feb 14, 2025
hailin0
reviewed
Feb 17, 2025
| if (resMatchedUrls.size() != 1) { | ||
| throw new SeaTunnelException( | ||
| String.format( | ||
| "Cannot find unique plugin jar for pluginIdentifier: %s -> %s", |
There was a problem hiding this comment.
add matchedUrl into error message
| } | ||
| return Optional.empty(); |
hailin0
approved these changes
Feb 25, 2025
Hisoka-X
approved these changes
Feb 25, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose of this pull request
Optimize the plugin discovery mechanism
Does this PR introduce any user-facing change?
How was this patch tested?
ut
Check list
New License Guide
release-note.