[Fix][Connector-V2] Fix paimon sink restore error #8598
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hey @uniding , Can you please guide me how did you verify the changes made by you actually solved the bug? I can ping you on the slack channel as well |
Hisoka-X
changed the title
Hisoka-X
reviewed
Feb 5, 2025
| @@ -245,7 +245,6 @@ public synchronized void init(long initializationTimestamp, boolean restart) thr | |||
| try { | |||
| Thread.currentThread().setContextClassLoader(classLoader); | |||
| if (!restart | |||
| && !logicalDag.isStartWithSavePoint() | |||
There was a problem hiding this comment.
- Execute the following command to start from savepoint, which will result in errors. Please refer to the bug for details
seatunnel.sh -c paimon.config -r 938988912087400449 -n m2p - After analysis and debugging, it was found that starting from savepoint does not execute the JobMaster::handleSaveMode method, so the handleSchemaSaveMode method of the PaimonSaveModeHandler class is not executed,Causing PaimonSink related member variables（paimonTable variable） to not be initialized resulting in a null pointer error when writing paimon
3.The relevant code call stack is shown in the following figure:
There was a problem hiding this comment.
I think we should move setLoadTable method out from handleSchemaSaveMode.
There was a problem hiding this comment.
I think we should move
setLoadTablemethod out fromhandleSchemaSaveMode.
why add !logicalDag.isStartWithSavePoint()?
There was a problem hiding this comment.
SchemaSaveMode used to create table or truncate table. When job start with savepoint, that's meaning the table already created or truncated. So we can not do it again.
Hisoka-X
added
the
don't merge
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#8460
Purpose of this pull request
Does this PR introduce any user-facing change?
How was this patch tested?
Check list
New License Guide
release-note.