Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Fix][Connector-V2] Fix CSV String type write type #8499

Merged
merged 11 commits into from
Jan 22, 2025
Merged

Conversation

corgy-w
Copy link
Contributor

@corgy-w corgy-w commented Jan 11, 2025

Purpose of this pull request

Fix CSV String type write type

Does this PR introduce any user-facing change?

How was this patch tested?

UT

Check list

# This is the 1st commit message:

[fix][Connector-V2] Fix CSV String type write type
@corgy-w corgy-w changed the title [fix][Connector-V2] Fix CSV String type write type [Fix][Connector-V2] Fix CSV String type write type Jan 13, 2025
@corgy-w
Copy link
Contributor Author

corgy-w commented Jan 16, 2025

@Hisoka-X ci has passed, accidentally merge dev, please review it

@Hisoka-X
Copy link
Member

Please fix test case.

@corgy-w
Copy link
Contributor Author

corgy-w commented Jan 17, 2025

Please fix test case.

#8448

@github-actions github-actions bot added the e2e label Jan 20, 2025
@corgy-w
Copy link
Contributor Author

corgy-w commented Jan 21, 2025

@Hisoka-X please review it

@hailin0 hailin0 merged commit 9268f5a into apache:dev Jan 22, 2025
3 checks passed
@litiliu
Copy link
Contributor

litiliu commented Mar 6, 2025

this pr is not related to any issue, what's the purpose of this pr? What does CSV String type write type mean?

@Hisoka-X
Copy link
Member

Hisoka-X commented Mar 6, 2025

this pr is not related to any issue, what's the purpose of this pr? What does CSV String type write type mean?

@corgy-w

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants