Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace getFirst with get #470

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

mdedetrich
Copy link
Contributor

So getFirst for getting an attribute is deprecated and you are instead meant to use get however this does have a different behaviour change (i.e. getFirst will get the first found attribute where as get will get the most specific attribute).

Since we are now in the 1.1.x branch these kinds of behaviour changes are allowed

@mdedetrich
Copy link
Contributor Author

Okay so as I expected, we are actually relying on the behaviour of getFirst since the tests have started failing, will do some digging here.

@mdedetrich
Copy link
Contributor Author

@jrudolph @raboof So I had a quick look at this and I don't know what to do here, it seems like making getFirst deprecated was a mistake or maybe it should only be deprecated for public and not private inter-pekko use cases?

The whole reason why getFirst is necessary is so that the withSizeLimit directive works correctly with nested routes and while it is possible to remove the deprecation of getFirst without using get in doing so it would just involve copying the implementation of it which means its not really solving a problem?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant