MINIFICPP-2462 - Divide libminifi #1902
Open
+9,250
−6,195
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
8 tasks
lordgamez
reviewed
Nov 28, 2024
There was a problem hiding this comment.
A few additional comments we talked about in person that should be done afterwards in different PRs and should create separate Jira tickets for:
- we should add Impl suffix to core/* files in future
- Move core/include/minifi-cpp directory minifi-api/include/minifi-cpp-api and later have a separate minifi-c-api directory for C API
- remove ThreadedRepository.h from minifi api and replace its usage with core::TraceableResource
adamdebreceni
force-pushed
the
minifi-api
branch
from
f5fecde to
53c2983
Compare
martinzink
approved these changes
Dec 13, 2024
There was a problem hiding this comment.
I've started to implement my new PR-s on top of this.
Dont want to further increase the size of the PR with nitpicks (since you touched almost the whole codebase I think we can skip the clang-tidy fixes aswell)
Great work LGTM 👍 please rebase and fix the rebase issues
adamdebreceni
force-pushed
the
minifi-api
branch
from
7033b8b to
c34633b
Compare
szaszm
reviewed
Jan 16, 2025
Comment on lines
+34
to
+35
| target_link_libraries(minifi-rocksdb-repos PUBLIC minifi-core minifi-extension-utils Threads::Threads) | ||
| target_link_libraries(minifi-rocksdb-repos PRIVATE $<LINK_ONLY:core-minifi>) |
There was a problem hiding this comment.
having both minifi-core and core-minifi is confusing, we should rename at least one of them
adamdebreceni
force-pushed
the
minifi-api
branch
from
c86e244 to
001d12c
Compare
martinzink
force-pushed
the
minifi-api
branch
from
001d12c to
47a6468
Compare
lordgamez
approved these changes
Feb 4, 2025
szaszm
reviewed
Feb 7, 2025
Co-authored-by: Márton Szász <[email protected]>
Co-authored-by: Márton Szász <[email protected]>
Co-authored-by: Márton Szász <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Thank you for submitting a contribution to Apache NiFi - MiNiFi C++.
In order to streamline the review of the contribution we ask you
to ensure the following steps have been taken:
For all changes:
Is there a JIRA ticket associated with this PR? Is it referenced
in the commit message?
Does your PR title start with MINIFICPP-XXXX where XXXX is the JIRA number you are trying to resolve? Pay particular attention to the hyphen "-" character.
Has your PR been rebased against the latest commit within the target branch (typically main)?
Is your initial contribution a single, squashed commit?
For code changes:
For documentation related changes:
Note:
Please ensure that once the PR is submitted, you check GitHub Actions CI results for build issues and submit an update to your PR as soon as possible.