-
Notifications
You must be signed in to change notification settings - Fork 19.7k
feat(devInfo): set devInfo into axis component #17698
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: v6
Are you sure you want to change the base?
Conversation
Thanks for your contribution! |
@sz-p Hi, thanks for your contribution! I marked this PR as a draft as it needs further discussion to determine the necessity, design, and implementation. |
Thanks for the work! This information are very useful in the visual editor of ECharts. Some suggestions or questions:
eCompName: 'barBackground' Is better to be component: 'series.bar',
element: 'background' // Other name better than element will be appreciated.
eCompName: 'candlestickEl' Is better to be component: 'series.candlestick'
element: 'main' // Perhaps it can be optional if there is only one type of elements in the series. Which is the most common case And eCompName: 'barRect' is better to be component: 'series.bar'
element: 'main' // Perhaps it can be optional if there is only one type of elements in the series. Which is the most common case
if (__DEV__) {
// The second parameters can be optional in most of series.
addDevInfo(el, 'series.bar', 'main');
} |
63cb828
to
ddaa123
Compare
The changes brought by this PR can be previewed at: https://echarts.apache.org/examples/editor?version=PR-17698@aa2af1a |
Brief Information
This pull request is in the type of:
What does this PR do?
Fixed issues
#17697
Details
Before: What was the problem?
After: How does it behave after the fixing?
Document Info
One of the following should be checked.
Misc
ZRender Changes
Related test cases or examples to use the new APIs
N.A.
Others
Merging options
Other information