-
Notifications
You must be signed in to change notification settings - Fork 19.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: markArea display filter correction #16861
Merged
Merged
Changes from 2 commits
Commits
Show all changes
11 commits
Select commit
Hold shift + click to select a range
8faf0f6
fix: markArea display filter correction
jiawulin001 8e0359e
fix lint style error and add test case
jiawulin001 a5bba65
Use BoundingRect.intersect instead of rectRectIntersect
jiawulin001 e90c07e
fix lint style errors
jiawulin001 cb80d3a
Fix another lint style error
jiawulin001 ad0c2dd
Update with new BoundingRect create
jiawulin001 16b2457
fix lint style error
jiawulin001 670ac68
test(markArea): add zoom interaction testing
pissang d87e51a
test(markArea): optimize test interactions
pissang d3366c9
fix: Update comment on MarkAreaView.ts
jiawulin001 cc3f4a7
optimize variable in MarkAreaView.ts
jiawulin001 File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We prefer using inline comment // here.
Also this comment seems to be outdated after new commits?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
For this one, I mean we are using a function
zonefilter
here, but actually returning true can achieve almost the same effect as using this function. The reason is that, when returning true,markArea
is always shown and will not be clipped however the grid changes, which solves the problem. When the coordinates does not include themarkArea
, it's automatically not shown. So in my opinion a function to check if the coordinates intersect withmarkArea
is unnecessary. Of course, keeping themarkArea
rendered may be problematic when there are huge amount of them, but in most cases one or twomarkArea
s would hardly affect performance.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Got it. Thanks for the detailed explanation. Perhaps we can tweak the description a bit to make it more clear. For example:
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good point. Comment updated.