Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(marker): marker state not restore after blur #16670

Merged
merged 6 commits into from
Mar 15, 2022
Merged
Show file tree
Hide file tree
Changes from 4 commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions src/component/marker/MarkerView.ts
Original file line number Diff line number Diff line change
Expand Up @@ -25,7 +25,7 @@ import ExtensionAPI from '../../core/ExtensionAPI';
import { makeInner } from '../../util/model';
import SeriesModel from '../../model/Series';
import Group from 'zrender/src/graphic/Group';
import { enterBlur } from '../../util/states';
import { enterBlur, leaveBlur } from '../../util/states';

const inner = makeInner<{
keep: boolean
Expand Down Expand Up @@ -71,7 +71,7 @@ abstract class MarkerView extends ComponentView {
inner(drawGroup).keep = true;
}

blurSeries(seriesModelList: SeriesModel[]) {
toggleBlurSeries(seriesModelList: SeriesModel[], isBlur: boolean) {
each(seriesModelList, seriesModel => {
const markerModel = MarkerModel.getMarkerModelFromSeries(
seriesModel,
Expand All @@ -81,7 +81,7 @@ abstract class MarkerView extends ComponentView {
const data = markerModel.getData();
data.eachItemGraphicEl(function (el) {
if (el) {
enterBlur(el);
isBlur ? enterBlur(el) : leaveBlur(el);
}
});
}
Expand Down
24 changes: 19 additions & 5 deletions src/util/states.ts
Original file line number Diff line number Diff line change
Expand Up @@ -61,6 +61,7 @@ import GlobalModel from '../model/Global';
import ExtensionAPI from '../core/ExtensionAPI';
import ComponentModel from '../model/Component';
import { error } from './log';
import type ComponentView from '../view/Component';

// Reserve 0 as default.
let _highlightNextDigit = 1;
Expand Down Expand Up @@ -427,19 +428,32 @@ function shouldSilent(el: Element, e: ElementEvent) {

export function allLeaveBlur(api: ExtensionAPI) {
const model = api.getModel();
const leaveBlurredSeries: SeriesModel[] = [];
const allComponents: ComponentModel[] = [];
model.eachComponent(function (componentType, componentModel) {
const componentStates = getComponentStates(componentModel);
const isSeries = componentType === 'series';
const view = isSeries ? api.getViewOfSeriesModel(componentModel as SeriesModel)
: api.getViewOfComponentModel(componentModel);
!isSeries && allComponents.push(componentModel);
susiwen8 marked this conversation as resolved.
Show resolved Hide resolved
isSeries && leaveBlurredSeries.push(componentModel as SeriesModel);
susiwen8 marked this conversation as resolved.
Show resolved Hide resolved
if (componentStates.isBlured) {
const view = componentType === 'series'
? api.getViewOfSeriesModel(componentModel as SeriesModel)
: api.getViewOfComponentModel(componentModel);
// Leave blur anyway
view.group.traverse(function (child) {
singleLeaveBlur(child);
});
}
if (view && (view as ComponentView).toggleBlurSeries) {
(view as ComponentView).toggleBlurSeries(leaveBlurredSeries, false, model);
susiwen8 marked this conversation as resolved.
Show resolved Hide resolved
}
componentStates.isBlured = false;
});
each(allComponents, function (component) {
const view = api.getViewOfComponentModel(component);
if (view && (view as ComponentView).toggleBlurSeries) {
(view as ComponentView).toggleBlurSeries(leaveBlurredSeries, false, model);
}
});
}

export function blurSeries(
Expand Down Expand Up @@ -519,8 +533,8 @@ export function blurSeries(
return;
}
const view = api.getViewOfComponentModel(componentModel);
if (view && view.blurSeries) {
view.blurSeries(blurredSeries, ecModel);
if (view && view.toggleBlurSeries) {
view.toggleBlurSeries(blurredSeries, true, ecModel);
}
});
}
Expand Down
8 changes: 4 additions & 4 deletions src/view/Component.ts
Original file line number Diff line number Diff line change
Expand Up @@ -107,11 +107,11 @@ class ComponentView {
}

/**
* Hook for blur target series.
* Can be used in marker for blur the markers
* Hook for toggle blur target series.
* Can be used in marker for blur or leave blur the markers
*/
blurSeries(seriesModels: SeriesModel[], ecModel: GlobalModel): void {
// Do nothing;
toggleBlurSeries(seriesModels: SeriesModel[], isBlur: boolean, ecModel: GlobalModel): void {
// Do nothing;
}

/**
Expand Down
4 changes: 3 additions & 1 deletion test/markPoint.html

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.