Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[5.0] feat(tooltip): allow adding classes to tooltip DOM and migrate changes to next branch in #12834. #13383

Merged
merged 2 commits into from
Oct 9, 2020

Conversation

plainheart
Copy link
Member

@plainheart plainheart commented Oct 2, 2020

Brief Information

This pull request is in the type of:

  • bug fixing
  • new feature
  • others

What does this PR do?

  • Allow users to add some classes to the tooltip dom to override default styles and get the dom by document.getElementsByClassName.
  • Migrate changes in PR fix: #12812 #12834 (relocate tooltip if chart resized)

Fixed issues

NA.

Details

Before: What was the problem?

The users cannot set some styles by className.

After: How is it fixed in this PR?

The users can override some styles by specifying className.

image
image

Usage

Are there any API changes?

  • The API has been changed.

Add a new option className to tooltip component. See apache/echarts-doc@f8843c9

Related test cases or examples to use the new APIs

Please refer to test/tooltip-windowResize.html

Others

Merging options

  • Please squash the commits into a single one when merge.

Other information

@echarts-bot
Copy link

echarts-bot bot commented Oct 2, 2020

Thanks for your contribution!
The community will review it ASAP. In the meanwhile, please checkout the coding standard and Wiki about How to make a pull request.

The pull request is marked to be PR: author is committer because you are a committer of this project.

Document changes are required in this PR. Please also make a PR to apache/incubator-echarts-doc for document changes. When the doc PR is merged, the maintainers will remove the PR: awaiting doc label.

@pissang pissang merged commit 25ceb56 into apache:next Oct 9, 2020
@echarts-bot
Copy link

echarts-bot bot commented Oct 9, 2020

Congratulations! Your PR has been merged. Thanks for your contribution! 👍

@pissang pissang changed the title feat(tooltip): allow adding classes to tooltip DOM and migrate changes to next branch in #12834. [5.0] feat(tooltip): allow adding classes to tooltip DOM and migrate changes to next branch in #12834. Oct 26, 2020
@plainheart plainheart deleted the feat/tooltip-class branch December 30, 2020 08:24
@plainheart plainheart removed the PR: awaiting doc Document changes is required for this PR. label Dec 31, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants