fix(bar-race): fix bug with animation #13121
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Brief Information
This pull request is in the type of:
What does this PR do?
Fix bug with bar race and move
realtimeSort
to be underseries
rather than axis and removesort
andsortSeriesIndex
. The original bar race PR is #12484.Fixed issues
Details
Before: What was the problem?
When there is currently an interchanging happening, calling
setOption
will make one frame with wrong bar widths (which is the target width after animation).After: How is it fixed in this PR?
Instead of using
during
, this PR useszr.on('rendered')
so that sorting is done after a frame is rendered, rather than before. It can fix many other potential problems with bar race.Usage
Are there any API changes?
Old:
New:
Related test cases or examples to use the new APIs
NA.
Others
Merging options
Other information