Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(line): overflow symbols should render if clip is false #11549 #11552

Merged
merged 2 commits into from
Nov 4, 2019
Merged

fix(line): overflow symbols should render if clip is false #11549 #11552

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
e71f104
fix(line): overflow symbols should render if clip is false #11549
SnailSword Nov 3, 2019
208d5ab
better way to judge clip or not
SnailSword Nov 4, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/chart/line/LineView.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -354,7 +354,7 @@ export default ChartView.extend({
// FIXME step not support polar
var step = !isCoordSysPolar && seriesModel.get('step');
var clipShapeForSymbol;
if (coordSys && coordSys.getArea) {
if (coordSys && coordSys.getArea && seriesModel.get('clip', true)) {
clipShapeForSymbol = coordSys.getArea();
// Avoid float number rounding error for symbol on the edge of axis extent.
// See #7913 and `test/dataZoom-clip.html`.
Expand Down