Merge pull request #18276 from susiwen8/18050

fix(dataset): object source contains `length` breaks render
apache · Feb 16, 2023 · 9191ab2 · 9191ab2
2 parents fc2be18 + da29a8d
commit 9191ab2
Show file tree

Hide file tree

Showing 2 changed files with 41 additions and 6 deletions.
diff --git a/src/data/Source.ts b/src/data/Source.ts
@@ -19,7 +19,7 @@
 
 import {
     isTypedArray, HashMap, clone, createHashMap, isArray, isObject, isArrayLike,
-    hasOwn, assert, each, map, isNumber, isString
+    hasOwn, assert, each, map, isNumber, isString, keys
 } from 'zrender/src/core/util';
 import {
     SourceFormat, SeriesLayoutBy, DimensionDefinition,
@@ -405,11 +405,7 @@ function objectRowsCollectDimensions(data: OptionSourceDataObjectRows): Dimensio
     let obj;
     while (firstIndex < data.length && !(obj = data[firstIndex++])) {} // jshint ignore: line
     if (obj) {
-        const dimensions: DimensionDefinitionLoose[] = [];
-        each(obj, function (value, key) {
-            dimensions.push(key);
-        });
-        return dimensions;
+        return keys(obj);
     }
 }
 

diff --git a/test/dataset-category.html b/test/dataset-category.html