Fix #5633 (when nameMap is used, name can not be obtained in tooltip …

…if no data exists in an area)
apache · Jul 12, 2017 · 640d354 · 640d354
1 parent b79b307
commit 640d354
Show file tree

Hide file tree

Showing 4 changed files with 9 additions and 3 deletions.
diff --git a/src/chart/map/MapSeries.js b/src/chart/map/MapSeries.js
@@ -82,7 +82,7 @@ define(function (require) {
             // Shallow clone
             option = zrUtil.extend({}, option);
 
-            option.data = geoCreator.getFilledRegions(option.data, mapName);
+            option.data = geoCreator.getFilledRegions(option.data, mapName, option.nameMap);
 
             return option;
         },

diff --git a/src/coord/geo/GeoModel.js b/src/coord/geo/GeoModel.js
@@ -34,7 +34,7 @@ define(function (require) {
             var option = this.option;
             var self = this;
 
-            option.regions = geoCreator.getFilledRegions(option.regions, option.map);
+            option.regions = geoCreator.getFilledRegions(option.regions, option.map, option.nameMap);
 
             this._optionModelMap = zrUtil.reduce(option.regions || [], function (optionModelMap, regionOpt) {
                 if (regionOpt.name) {

diff --git a/src/coord/geo/geoCreator.js b/src/coord/geo/geoCreator.js
@@ -245,11 +245,13 @@ define(function (require) {
          * Fill given regions array
          * @param  {Array.<Object>} originRegionArr
          * @param  {string} mapName
+         * @param  {Object} [nameMap]
          * @return {Array}
          */
-        getFilledRegions: function (originRegionArr, mapName) {
+        getFilledRegions: function (originRegionArr, mapName, nameMap) {
             // Not use the original
             var regionsArr = (originRegionArr || []).slice();
+            nameMap = nameMap || {};
 
             var map = geoCreator.getMap(mapName);
             var geoJson = map && map.geoJson;
@@ -269,6 +271,9 @@ define(function (require) {
             for (var i = 0; i < features.length; i++) {
                 var name = features[i].properties.name;
                 if (!dataNameMap.get(name)) {
+                    if (nameMap.hasOwnProperty(name)) {
+                        name = nameMap[name];
+                    }
                     regionsArr.push({
                         name: name
                     });

diff --git a/test/mapWorld.html b/test/mapWorld.html
@@ -19,6 +19,7 @@
             require([
                 'echarts',
                 'echarts/chart/map',
+                'echarts/component/tooltip',
                 'echarts/component/legend',
                 'echarts/component/geo',
                 'echarts/component/visualMap'