Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[fix doc]-Correct spelling errors in words #420

Closed
wants to merge 9 commits into from
Closed

[fix doc]-Correct spelling errors in words #420

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
9 commits
Select commit Hold shift + click to select a range
169af79
fix:delete aciton: hightlight and downplay
huanglp6016 Aug 3, 2022
2363da2
fix:delete events: hightlight and downplay
huanglp6016 Aug 3, 2022
5581a5f
Merge branch 'apache:master' into master
gitforhlp Aug 16, 2022
45532b2
revert:hightlight and downplay aciton and event
huanglp6016 Aug 16, 2022
4186dfa
Merge branch 'apache:master' into master
gitforhlp Aug 22, 2022
094c733
change hightlight and downplay doc
huanglp6016 Aug 26, 2022
2a1b4f9
Merge branch 'master' of https://github.com/gitforhlp/echarts-doc
huanglp6016 Aug 26, 2022
4f966bb
change hightlight and downplay doc again
huanglp6016 Aug 29, 2022
5035dab
Merge branch 'apache:master' into master
gitforhlp Aug 22, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions en/api/action.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -41,7 +41,7 @@ Chart actions supported by ECharts are triggered through [dispatchAction](~echar
Highlights specified data graphics.

```ts
// If highlight series:
// If highlight series（in the `sunburst` series,`highlight` has been deprecated since `v5.0.0`, please use `sunburstHighlight` instead）：
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think sunburstHighlight is deprecated rather than highlight and your current change conflicts with your previous change in apache/echarts#17587.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also, the changes don't match your PR title. I didn't see any fix for spelling errors.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have modified it a moments ago,please view again, thanks

dispatchAction({
type: 'highlight',

Expand All @@ -66,7 +66,7 @@ dispatchAction({
Downplay specified data graphics.

```ts
// If downplay series:
// If downplay series（in the `sunburst` series,`downplay` has been deprecated since `v5.0.0`, please use `sunburstUnhighlight` instead）：
dispatchAction({
type: 'downplay',

Expand Down
4 changes: 2 additions & 2 deletions zh/api/action.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -40,7 +40,7 @@ ECharts 中支持的图表行为，通过 [dispatchAction](~echartsInstance.disp
高亮指定的数据图形。

```ts
// 如果要高亮系列：
// 如果要高亮系列（旭日图`sunburst`,从 `v5.0.0` 开始`highlight` 已被弃用，请使用 `sunburstHighlight` 代替）：
dispatchAction({
type: 'highlight',

Expand All @@ -64,7 +64,7 @@ dispatchAction({
取消高亮指定的数据图形。

```ts
// 如果要取消高亮系列：
// 如果要取消高亮系列（旭日图`sunburst`,从 `v5.0.0` 开始`downplay` 已被弃用，请使用 `sunburstUnhighlight` 代替）：
dispatchAction({
type: 'downplay',

Expand Down