Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

honor table name for csv/parquet scan in ballista plan serde #629

Merged
merged 2 commits into from
Jun 27, 2021
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
22 changes: 16 additions & 6 deletions ballista/rust/core/src/serde/logical_plan/from_proto.rs
Original file line number Diff line number Diff line change
Expand Up @@ -126,9 +126,14 @@ impl TryInto<LogicalPlan> for &protobuf::LogicalPlanNode {
projection = Some(column_indices);
}

LogicalPlanBuilder::scan_csv(&scan.path, options, projection)?
.build()
.map_err(|e| e.into())
LogicalPlanBuilder::scan_csv_with_name(
&scan.path,
options,
projection,
&scan.table_name,
)?
.build()
.map_err(|e| e.into())
}
LogicalPlanType::ParquetScan(scan) => {
let projection = match scan.projection.as_ref() {
Expand All @@ -151,9 +156,14 @@ impl TryInto<LogicalPlan> for &protobuf::LogicalPlanNode {
Some(r?)
}
};
LogicalPlanBuilder::scan_parquet(&scan.path, projection, 24)? //TODO concurrency
.build()
.map_err(|e| e.into())
LogicalPlanBuilder::scan_parquet_with_name(
&scan.path,
projection,
24,
&scan.table_name,
)? //TODO concurrency
.build()
.map_err(|e| e.into())
}
LogicalPlanType::Sort(sort) => {
let input: LogicalPlan = convert_box_required!(sort.input)?;
Expand Down
2 changes: 1 addition & 1 deletion benchmarks/run.sh
Original file line number Diff line number Diff line change
Expand Up @@ -20,7 +20,7 @@ set -e
# This bash script is meant to be run inside the docker-compose environment. Check the README for instructions

cd /
for query in 1 3 5 6 7 8 9 10 12
for query in 1 3 5 6 10 12
do
/tpch benchmark ballista --host ballista-scheduler --port 50050 --query $query --path /data --format tbl --iterations 1 --debug
done
24 changes: 22 additions & 2 deletions datafusion/src/logical_plan/builder.rs
Original file line number Diff line number Diff line change
Expand Up @@ -118,19 +118,39 @@ impl LogicalPlanBuilder {
path: &str,
options: CsvReadOptions,
projection: Option<Vec<usize>>,
) -> Result<Self> {
Self::scan_csv_with_name(path, options, projection, path)
}

/// Scan a CSV data source and register it with a given table name
pub fn scan_csv_with_name(
path: &str,
options: CsvReadOptions,
projection: Option<Vec<usize>>,
table_name: &str,
) -> Result<Self> {
let provider = Arc::new(CsvFile::try_new(path, options)?);
Self::scan(path, provider, projection)
Self::scan(table_name, provider, projection)
}

/// Scan a Parquet data source
pub fn scan_parquet(
path: &str,
projection: Option<Vec<usize>>,
max_concurrency: usize,
) -> Result<Self> {
Self::scan_parquet_with_name(path, projection, max_concurrency, path)
}

/// Scan a Parquet data source and register it with a given table name
pub fn scan_parquet_with_name(
path: &str,
projection: Option<Vec<usize>>,
max_concurrency: usize,
table_name: &str,
) -> Result<Self> {
let provider = Arc::new(ParquetTable::try_new(path, max_concurrency)?);
Self::scan(path, provider, projection)
Self::scan(table_name, provider, projection)
}

/// Scan an empty data source, mainly used in tests
Expand Down