Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make it concurrently to launch tasks to executors #557

Merged
merged 2 commits into from
Dec 13, 2022
Merged

Make it concurrently to launch tasks to executors #557

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
b406f35
Make it concurrently to launch tasks to executors
kyotoYaho Dec 9, 2022
961f719
Refine for comments
kyotoYaho Dec 13, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
79 changes: 49 additions & 30 deletions ballista/scheduler/src/state/mod.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -236,47 +236,66 @@ impl<T: 'static + AsLogicalPlan, U: 'static + AsExecutionPlan> SchedulerState<T,
}
}

let mut join_handles = vec![];
for (executor_id, tasks) in executor_stage_assignments.into_iter() {
let tasks: Vec<Vec<TaskDescription>> = tasks.into_values().collect();
// Total number of tasks to be launched for one executor
let n_tasks: usize =
tasks.iter().map(|stage_tasks| stage_tasks.len()).sum();

match self
.executor_manager
.get_executor_metadata(&executor_id)
.await
{
Ok(executor) => {
if let Err(e) = self
.task_manager
.launch_multi_task(
&executor,
tasks,
&self.executor_manager,
)
.await
{
error!("Failed to launch new task: {:?}", e);
for _i in 0..n_tasks {
unassigned_reservations.push(
ExecutorReservation::new_free(
executor_id.clone(),
),
);
let task_manager = self.task_manager.clone();
let executor_manager = self.executor_manager.clone();
let join_handle = tokio::spawn(async move {
let success = match executor_manager
.get_executor_metadata(&executor_id)
.await
{
Ok(executor) => {
if let Err(e) = task_manager
.launch_multi_task(
&executor,
tasks,
&executor_manager,
)
.await
{
error!("Failed to launch new task: {:?}", e);
false
} else {
true
}
}
}
Err(e) => {
error!("Failed to launch new task, could not get executor metadata: {:?}", e);
for _i in 0..n_tasks {
unassigned_reservations.push(
ExecutorReservation::new_free(executor_id.clone()),
);
Err(e) => {
error!("Failed to launch new task, could not get executor metadata: {:?}", e);
false
}
};
if success {
vec![]
} else {
vec![
ExecutorReservation::new_free(executor_id.clone(),);
n_tasks
]
}
}
});
join_handles.push(join_handle);
}

let unassigned_executor_reservations =
futures::future::join_all(join_handles)
.await
.into_iter()
.collect::<std::result::Result<
Vec<Vec<ExecutorReservation>>,
tokio::task::JoinError,
>>()?;
unassigned_reservations.append(
&mut unassigned_executor_reservations
.into_iter()
.flatten()
.collect::<Vec<ExecutorReservation>>(),
);
(unassigned_reservations, pending_tasks)
}
Err(e) => {
Expand Down