Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

scheduler now verifies that file:// ListingTable URLs are accessible #414

Merged
merged 7 commits into from
Oct 23, 2022
Merged

scheduler now verifies that file:// ListingTable URLs are accessible #414

Changes from 1 commit
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
708ac9c
scheduler now verifies that ListingTable URLs are accessible
andygrove Oct 20, 2022
af3f3c8
clippy
andygrove Oct 21, 2022
514be8e
clippy
andygrove Oct 21, 2022
def8eb4
fix
andygrove Oct 21, 2022
35c6e43
fix
andygrove Oct 21, 2022
90a46d2
address feedback
andygrove Oct 21, 2022
693348d
fix
andygrove Oct 21, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
fix
  • Loading branch information
@andygrove
andygrove committed Oct 21, 2022
commit 35c6e43b5ac044f61b4b58a214762f76fd774971
2 changes: 1 addition & 1 deletion ballista/scheduler/src/state/mod.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -279,7 +279,7 @@ impl<T: 'static + AsLogicalPlan, U: 'static + AsExecutionPlan> SchedulerState<T,
if let Some(table) = provider.as_any().downcast_ref::<ListingTable>()
{
for url in table.table_paths() {
// remove file:// prefix and verify that the file is accessible
// remove file:/// prefix and verify that the file is accessible
let url = url.as_str();
let url = url.strip_prefix("file:///").unwrap_or(url);
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Will it check files on S3 or HDFS? Sometimes, the table_paths may be of tens of thousands. Here, the check logic may be very time consuming.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I pushed a change so that this check is only performed for files on the local file system (starting with file:///) and it now only checks the first file

ListingTableUrl::parse(url)
Expand Down