Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

AIP-83 Restore uniqueness constraint on logical date and make logical date nullable #46232

Open
wants to merge 19 commits into
base: main
Choose a base branch
from

Conversation

vatsrahul1001
Copy link
Collaborator

@vatsrahul1001 vatsrahul1001 commented Jan 29, 2025

Closes: #46187


^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named {pr_number}.significant.rst or {issue_number}.significant.rst, in newsfragments.

@vatsrahul1001 vatsrahul1001 marked this pull request as ready for review January 29, 2025 10:16
@vatsrahul1001 vatsrahul1001 marked this pull request as draft January 29, 2025 10:42
@vatsrahul1001
Copy link
Collaborator Author

Few tests are failing looking into it

@vatsrahul1001
Copy link
Collaborator Author

Failing test cases will require change in backfill reprocess behaviour, I have create PR which will fix these failing tests

@uranusjr
Copy link
Member

uranusjr commented Feb 3, 2025

What’s the order we should merge the two PRs? Tests are not passing on this one, but the other PR needs this to be merged first.

--

Edit: Talked to Rahul, this should be made greeen and go in first.

Comment on lines 1308 to 1315
or (
task.start_date is None
or (self.logical_date is not None and task.start_date <= self.logical_date)
)
and (
task.end_date is None
or (self.logical_date is not None and self.logical_date <= task.end_date)
)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
or (
task.start_date is None
or (self.logical_date is not None and task.start_date <= self.logical_date)
)
and (
task.end_date is None
or (self.logical_date is not None and self.logical_date <= task.end_date)
)
or (
task.start_date is None
or self.logical_date is None
or task.start_date <= self.logical_date
)
and (task.end_date is None or self.logical_date is None or self.logical_date <= task.end_date)

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I suspect this "might" be the correct condition.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes this one is correct. Thanks @Lee-W

@vatsrahul1001
Copy link
Collaborator Author

vatsrahul1001 commented Feb 3, 2025

What’s the order we should merge the two PRs? Tests are not passing on this one, but the other PR needs this to be merged first.

--

Edit: Talked to Rahul, this should be made greeen and go in first.

@uranusjr Fixed failing tests now only failing tests are now related to backfill test_reprocess_behavior which are fixed in #46295 .

@vatsrahul1001 vatsrahul1001 requested a review from Lee-W February 3, 2025 12:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

AIP-83 Restore uniqueness constraint on logical date and make logical date nullable
3 participants