Enable already existing "task.scheduled_duration" metric #46009
+915
−739
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AutomationDev85
requested review from
ephraimbuddy,
dstandish,
hussein-awala,
bbovenzi,
pierrejeambrun,
ryanahamilton,
jscheffl,
potiuk,
XD-DENG and
ashb
as code owners
boring-cyborg
bot
added
area:API
There was a problem hiding this comment.
Copilot reviewed 8 out of 23 changed files in this pull request and generated no comments.
Files not reviewed (15)
- airflow/api_fastapi/core_api/openapi/v1-generated.yaml: Language not supported
- docs/apache-airflow/img/airflow_erd.sha256: Language not supported
- docs/apache-airflow/migrations-ref.rst: Language not supported
- airflow/api_fastapi/core_api/datamodels/task_instances.py: Evaluated as low risk
- airflow/api_connexion/schemas/task_instance_schema.py: Evaluated as low risk
- tests/api_connexion/endpoints/test_task_instance_endpoint.py: Evaluated as low risk
- airflow/models/dag.py: Evaluated as low risk
- tests/api_connexion/schemas/test_task_instance_schema.py: Evaluated as low risk
- airflow/models/dagrun.py: Evaluated as low risk
- airflow/models/taskinstancehistory.py: Evaluated as low risk
- tests/api_connexion/endpoints/test_mapped_task_instance_endpoint.py: Evaluated as low risk
- airflow/models/taskinstance.py: Evaluated as low risk
- tests/api_fastapi/core_api/routes/public/test_task_instances.py: Evaluated as low risk
- airflow/models/trigger.py: Evaluated as low risk
- airflow/triggers/base.py: Evaluated as low risk
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
This PR enables the task.scheduled_duration metric. It is already described here:
https://airflow.apache.org/docs/apache-airflow/stable/administration-and-deployment/logging-monitoring/metrics.html#timers
Search for "task.scheduled_duration"
The metric is not working at the moment as the scheduled_dttm field is missing in the task_instance table.
I hope I catched all points in the code were the task_instance is set to scheduled state to collect the right time and that I understood the metric in the right way.
Idea of this PR to keep it as simple as possible to enable this metric.
Details of changes:
Looking forward to start the discussion about this metric and getting this live with Airflow 3.