Replace external_trigger check with DagRunType
#45961
Open
+537
−585
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
boring-cyborg
bot
added
area:API
jason810496
force-pushed
the
replace-external_trigger-with-dag-run-type
branch
3 times, most recently
from
45cf835 to
9eef4f1
Compare
jason810496
changed the title
external_trigger check with DagRunTypeexternal_trigger check with DagRunType
jason810496
requested review from
ephraimbuddy,
potiuk,
ashb,
jedcunningham,
mobuchowski,
bbovenzi,
pierrejeambrun,
ryanahamilton,
jscheffl and
XD-DENG
as code owners
ashb
reviewed
Jan 24, 2025
airflow/migrations/versions/0056_3_0_0_remove_external_trigger_field.py
Outdated
Show resolved
Hide resolved
airflow/migrations/versions/0056_3_0_0_remove_external_trigger_field.py
Outdated
Show resolved
Hide resolved
airflow/migrations/versions/0056_3_0_0_remove_external_trigger_field.py
Outdated
Show resolved
Hide resolved
airflow/models/dagrun.py
Outdated
| @@ -1227,11 +1217,11 @@ def _emit_true_scheduling_delay_stats_for_finished_state(self, finished_tis: lis | |||
| rid of the outliers on the stats side through dashboards tooling. | |||
|
|
|||
| Note that the stat will only be emitted for scheduler-triggered DAG runs | |||
| (i.e. when ``external_trigger`` is *False* and ``clear_number`` is equal to 0). | |||
| (i.e. when ``run_type`` is *MANUAL* and ``clear_number`` is equal to 0). | |||
There was a problem hiding this comment.
Suggested change
| (i.e. when ``run_type`` is *MANUAL* and ``clear_number`` is equal to 0). | |
| (i.e. when ``run_type`` is not *MANUAL* and ``clear_number`` is equal to 0). |
Though this brings up another question: How should this function deal with run_type==BACKFILL?
There was a problem hiding this comment.
How about adding an externally_triggered_type in airflow.utils.types? Instead of checking run_type == DagRunType.MANUAL, we could use run_type in externally_triggered_type. WDYT?
externally_triggered_type: frozenset[DagRunType] = frozenset([DagRunType.BACKFILL_JOB, DagRunType.MANUAL, DagRunType.ASSET_TRIGGERED])
providers/src/airflow/providers/standard/operators/latest_only.py
Outdated
Show resolved
Hide resolved
| @@ -53,7 +54,7 @@ def choose_branch(self, context: Context) -> str | Iterable[str]: | |||
| # If the DAG Run is externally triggered, then return without | |||
| # skipping downstream tasks | |||
| dag_run: DagRun = context["dag_run"] # type: ignore[assignment] | |||
| if dag_run.external_trigger: | |||
| if dag_run.run_type == DagRunType.MANUAL: | |||
There was a problem hiding this comment.
Ditto here about BACKFILL. Need to decide how to handle this
ashb
added
the
airflow3.0:breaking
jason810496
force-pushed
the
replace-external_trigger-with-dag-run-type
branch
from
a65904d to
2fee34c
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes: #45932
^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named
{pr_number}.significant.rstor{issue_number}.significant.rst, in newsfragments.