[EDGE]Enable edge worker maintenance mode #45958
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 28 commits
January 16, 2025 14:37
added 22 commits
January 23, 2025 10:37
…/github.com/boschglobal/airflow into feature/enable-edge-worker-maintenance-mode
majorosdonat
changed the title
jscheffl
added
type:new-feature
There was a problem hiding this comment.
Copilot reviewed 5 out of 15 changed files in this pull request and generated no comments.
Files not reviewed (10)
- providers/edge/README.rst: Language not supported
- providers/edge/docs/changelog.rst: Language not supported
- providers/edge/src/airflow/providers/edge/openapi/edge_worker_api_v1.yaml: Language not supported
- providers/edge/src/airflow/providers/edge/plugins/templates/edge_worker_hosts.html: Language not supported
- providers/edge/src/airflow/providers/edge/cli/api_client.py: Evaluated as low risk
- providers/edge/src/airflow/providers/edge/get_provider_info.py: Evaluated as low risk
- providers/edge/provider.yaml: Evaluated as low risk
- providers/edge/tests/provider_tests/edge/cli/test_edge_command.py: Evaluated as low risk
- providers/edge/src/airflow/providers/edge/init.py: Evaluated as low risk
- providers/edge/pyproject.toml: Evaluated as low risk
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Maintenance mode is enabled for the edge worker. In maintenance mode, the worker is alive, but cannot consume any jobs.
The maintenance mode can be triggered by a button from the edge worker status page. It writes the state "maintenance request" directly to the database as worker state. Then the worker will go to maintenance pending if there are running jobs, and maintenance mode if all jobs have finished.
When exiting maintenance mode, maintenance exit is written to the database. Then the worker will switch to running state if it was in state maintenance pending, and to idle if it was in maintenance mode.
Why do we need the state maintenance exit?
If the user requested maintenance, so the maintenance request is in the database, and the user wants to exit maintenance immidiately e.g. for misclick, then we will not know if we should write running or idle to the database.
^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named
{pr_number}.significant.rstor{issue_number}.significant.rst, in newsfragments.