Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement fetching consumer_secret from Salesforce connection #45954

Merged

Conversation

kanagaraj-dhanapal-89
Copy link
Contributor

This PR introduces a new feature that allows users to retrieve the consumer_secret directly from the Connections service.


^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named {pr_number}.significant.rst or {issue_number}.significant.rst, in newsfragments.

This PR introduces a new feature that allows users to retrieve the consumer_secret directly from the Connections service.
Copy link

boring-cyborg bot commented Jan 23, 2025

Congratulations on your first Pull Request and welcome to the Apache Airflow community! If you have any issues or are unsure about any anything please check our Contributors' Guide (https://github.com/apache/airflow/blob/main/contributing-docs/README.rst)
Here are some useful points:

  • Pay attention to the quality of your code (ruff, mypy and type annotations). Our pre-commits will help you with that.
  • In case of a new feature add useful documentation (in docstrings or in docs/ directory). Adding a new operator? Check this short guide Consider adding an example DAG that shows how users should use it.
  • Consider using Breeze environment for testing locally, it's a heavy docker but it ships with a working Airflow and a lot of integrations.
  • Be patient and persistent. It might take some time to get a review or get the final approval from Committers.
  • Please follow ASF Code of Conduct for all communication including (but not limited to) comments on Pull Requests, Mailing list and Slack.
  • Be sure to read the Airflow Coding style.
  • Always keep your Pull Requests rebased, otherwise your build might fail due to changes not related to your commits.
    Apache Airflow is a community-driven project and together we are making it better 🚀.
    In case of doubts contact the developers at:
    Mailing List: [email protected]
    Slack: https://s.apache.org/airflow-slack

Copy link
Contributor

@eladkal eladkal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please ammend the commit and PR title with meeaningful description

kanagaraj-dhanapal-89 and others added 2 commits January 23, 2025 19:49
This PR introduces a new feature that allows users to retrieve the consumer_secret directly from the Connections service.
@kanagaraj-dhanapal-89 kanagaraj-dhanapal-89 changed the title Update salesforce.py Update salesforce.py - Salesforce: Implement fetching consumer_secret from Airflow Connections Jan 23, 2025
k0d04mr added 2 commits January 23, 2025 20:23
…ns and connection form widgets

This PR introduces a new feature that allows users to retrieve the consumer_secret directly from the Connections service.
…ns and connection form widgets

This PR introduces a new feature that allows users to retrieve the consumer_secret directly from the Connections service.
@eladkal eladkal changed the title Update salesforce.py - Salesforce: Implement fetching consumer_secret from Airflow Connections Implement fetching consumer_secret from Salesforce connection Jan 23, 2025
k0d04mr and others added 4 commits January 24, 2025 00:17
…ns and connection form widgets

This PR introduces a new feature that allows users to retrieve the consumer_secret directly from the Connections service.
…ns and connection form widgets + UTC's update

This PR introduces a new feature that allows users to retrieve the consumer_secret directly from the Connections service.
@kanagaraj-dhanapal-89
Copy link
Contributor Author

Please ammend the commit and PR title with meeaningful description

Done

@eladkal
Copy link
Contributor

eladkal commented Jan 24, 2025

Tests are failing

FAILED providers/tests/salesforce/hooks/test_salesforce.py::TestSalesforceHook::test_get_conn_default_to_none - AssertionError: expected call not found.
Expected: Salesforce(username=None, *** security_token=None, domain=None, session_id=None, instance=None, instance_url=None, organizationId=None, version='59.0', proxies=None, session=None, client_id=None, consumer_key=None, privatekey_file=None, privatekey=None)
Actual: Salesforce(username=None, *** security_token=None, domain=None, session_id=None, instance=None, instance_url=None, organizationId=None, version='59.0', proxies=None, session=None, client_id=None, consumer_key=None, consumer_secret=None, privatekey_file=None, privatekey=None)

k0d04mr and others added 3 commits January 24, 2025 12:37
…ns and connection form widgets

This PR introduces a new feature that allows users to retrieve the consumer_secret directly from the Connections service.
@kanagaraj-dhanapal-89
Copy link
Contributor Author

Tests are failing

FAILED providers/tests/salesforce/hooks/test_salesforce.py::TestSalesforceHook::test_get_conn_default_to_none - AssertionError: expected call not found.
Expected: Salesforce(username=None, *** security_token=None, domain=None, session_id=None, instance=None, instance_url=None, organizationId=None, version='59.0', proxies=None, session=None, client_id=None, consumer_key=None, privatekey_file=None, privatekey=None)
Actual: Salesforce(username=None, *** security_token=None, domain=None, session_id=None, instance=None, instance_url=None, organizationId=None, version='59.0', proxies=None, session=None, client_id=None, consumer_key=None, consumer_secret=None, privatekey_file=None, privatekey=None)

checking

@kanagaraj-dhanapal-89
Copy link
Contributor Author

Tests are failing

FAILED providers/tests/salesforce/hooks/test_salesforce.py::TestSalesforceHook::test_get_conn_default_to_none - AssertionError: expected call not found.
Expected: Salesforce(username=None, *** security_token=None, domain=None, session_id=None, instance=None, instance_url=None, organizationId=None, version='59.0', proxies=None, session=None, client_id=None, consumer_key=None, privatekey_file=None, privatekey=None)
Actual: Salesforce(username=None, *** security_token=None, domain=None, session_id=None, instance=None, instance_url=None, organizationId=None, version='59.0', proxies=None, session=None, client_id=None, consumer_key=None, consumer_secret=None, privatekey_file=None, privatekey=None)

checking

I hope its fixed now, could you please check?

@eladkal
Copy link
Contributor

eladkal commented Jan 26, 2025

@eladkal eladkal merged commit 63f3b0e into apache:main Jan 26, 2025
61 checks passed
Copy link

boring-cyborg bot commented Jan 26, 2025

Awesome work, congrats on your first merged pull request! You are invited to check our Issue Tracker for additional contributions.

@utkarsharma2 utkarsharma2 added the changelog:skip Changes that should be skipped from the changelog (CI, tests, etc..) label Jan 27, 2025
got686-yandex pushed a commit to got686-yandex/airflow that referenced this pull request Jan 30, 2025
…#45954)

This PR introduces a new feature that allows users to retrieve the consumer_secret directly from the Connections service.

---------

Co-authored-by: k0d04mr <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area:providers changelog:skip Changes that should be skipped from the changelog (CI, tests, etc..) provider:salesforce
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants