Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: upgrade to webpackbar 3.1.2 #13067

Merged
merged 1 commit into from
Nov 10, 2018
Merged

Conversation

pi0
Copy link
Contributor

@pi0 pi0 commented Nov 9, 2018

Hi!
I'm so excited to see webpackbar is being used for ant-design build system! There were minor inconsistencies by one of the 3.x patches that caused an error reported in unjs/webpackbar#30 (Related commit 5204b45) (Sorry for that 🙏) After that I tried to personally investigate some inconsistencies and finally with 3.1.2 not only problem resolved, but webpackbar is much stable with concurrent logs!

IMPORTANT: As antd-tools is a dep of this repository and also uses webpackbar, ant-design/antd-tools#81 should be better applied and published first.

kapture 2018-11-10 at 2 59 50

  • Make sure that you propose PR to right branch: bugfix for master, feature for branch feature.
  • Make sure that you follow antd's code convention.
  • Run npm run lint and fix those errors before submitting in order to keep consistent code style.
  • Rebase before creating a PR to keep commit history clear.
  • Add some descriptions and refer relative issues for you PR.

Extra checklist:

if isBugFix :

  • Make sure that you add at least one unit test for the bug which you had fixed.

elif isNewFeature :

  • Update API docs for the component.
  • Update/Add demo to demonstrate new feature.
  • Update TypeScript definition for the component.
  • Add unit tests for the feature.

@netlify
Copy link

netlify bot commented Nov 9, 2018

Deploy preview for ant-design ready!

Built with commit 513daa8

https://deploy-preview-13067--ant-design.netlify.com

@afc163
Copy link
Member

afc163 commented Nov 10, 2018

😂 Thx for sending PR and loves your work~ @pi0

@afc163 afc163 merged commit 8900c5e into ant-design:master Nov 10, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants