Skip to content
This repository was archived by the owner on Jan 26, 2021. It is now read-only.

Added fix to disable unauthorized access by volunteers #430

Closed
wants to merge 5 commits into from
Closed

Added fix to disable unauthorized access by volunteers #430

wants to merge 5 commits into from

Conversation

Yureien
Copy link
Contributor

@Yureien Yureien commented Jan 13, 2017

Fixes issue #326

In addition to the links mentioned in the issue, I've also fixed these urls -

  1. /volunteer/edit/ - Previously could be accessed by anyone
  2. /volunteer/add_hours/ - Previously could be accessed by anyone
  3. /volunteer/edit_hours/ - Previously could be accessed by anyone
  4. /shift/cancel/ - Previously showed an Http 403 page, fixed to show same error page as other ones.

Here is the screenshot -
screenshot from 2017-01-13 23-10-43

PS: In this commit, administrators cannot see the volunteer restricted pages too except shift sign-up page. If this needs to be changed, please tell me.

@Yureien
Copy link
Contributor Author

Yureien commented Jan 13, 2017

There are some more test errors, I'll fix them by tomorrow

@coveralls
Copy link

Coverage Status

Coverage increased (+0.2%) to 91.531% when pulling 024fcdd on InfernoCoder:VOLUNTEER_URL_FIX into 46171dd on systers:develop.

Copy link
Contributor

@smarshy smarshy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the work and especially for spotting the extra urls. This seems to be working fine.

@smarshy
Copy link
Contributor

smarshy commented Jan 27, 2017

@InfernoCoder There are conflicts in this PR. Please resolve them. Let me know if you need help

@coveralls
Copy link

Coverage Status

Coverage decreased (-0.03%) to 91.72% when pulling a1daa4e on InfernoCoder:VOLUNTEER_URL_FIX into 880a3c8 on systers:develop.

@Yureien
Copy link
Contributor Author

Yureien commented Jan 27, 2017

@smarshy Fixed the conflicts

@Yureien
Copy link
Contributor Author

Yureien commented Feb 11, 2017

This PR is closed and moved to #449 .

@Yureien Yureien closed this Feb 11, 2017
@Yureien Yureien deleted the VOLUNTEER_URL_FIX branch February 11, 2017 17:24
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants