Don't implement FirebaseApp, this leads to fragility (requires Firebase 5.0.2) #1630
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jamesdaniels
changed the title
|
Hopefully the bangs won't be needed much longer, seems to have attention in the JS SDK firebase/firebase-js-sdk#793 |
jamesdaniels
changed the title
jamesdaniels
changed the title
|
Darn, looks like I missed up something in the merge; will address. |
|
Going to close for now, having trouble with the exports. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist
yarn install,yarn testrun successfully? (yes/no; required)Description
Depends on #1628
Code sample