Skip to content
This repository has been archived by the owner on May 29, 2019. It is now read-only.

Commit

Permalink
fix(tabs): revert template change
Browse files Browse the repository at this point in the history
- Reverts template change to tab
- Adds warning if one desires more complex HTML inside the tab
  • Loading branch information
wesleycho committed Jan 15, 2016
1 parent de24927 commit c49e9b4
Show file tree
Hide file tree
Showing 3 changed files with 6 additions and 50 deletions.
6 changes: 5 additions & 1 deletion src/tabs/docs/readme.md
Original file line number Diff line number Diff line change
Expand Up @@ -23,7 +23,7 @@ AngularJS version of the tabs directive.
<i class="glyphicon glyphicon-eye-open"></i>
_(Default: `false`)_ -
Whether tab is currently selected.

* `deselect()`
<small class="badge">$</small>
_(Default: `null`)_ -
Expand All @@ -46,3 +46,7 @@ AngularJS version of the tabs directive.
### Tabset heading

Instead of the `heading` attribute on the `uib-tabset`, you can use an `uib-tab-heading` element inside a tabset that will be used as the tabset's header. There you can use HTML as well.

### Known issues

To use clickable elements within the tab, you have override the tab template to use div elements instead of anchor elements, and replicate the desired styles from Bootstrap's CSS. This is due to browsers interpreting anchor elements as the target of any click event, which triggers routing when certain elements such as buttons are nested inside the anchor element.
48 changes: 0 additions & 48 deletions src/tabs/tabs.css

This file was deleted.

2 changes: 1 addition & 1 deletion template/tabs/tab.html
Original file line number Diff line number Diff line change
@@ -1,3 +1,3 @@
<li ng-class="{active: active, disabled: disabled}" class="uib-tab">
<div ng-click="select()" uib-tab-heading-transclude>{{heading}}</div>
<a href ng-click="select()" uib-tab-heading-transclude>{{heading}}</a>
</li>

0 comments on commit c49e9b4

Please sign in to comment.