Skip to content

nf: Angular I18n support #456

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 28 commits into from
Closed

nf: Angular I18n support #456

wants to merge 28 commits into from

Conversation

refactorTractor
Copy link

@refactorTractor refactorTractor commented Feb 1, 2024 •
edited
Loading

closes #413

Angular i18n support in native federation

This is how i18n support could play out in my opinion:

  • Shared entries/packages build just as they used to.
  • Exposed entries are built by the angular application internal builder
  • index.html-s are found in the build output, and each transformed
  • remoteEntries are copied next to index.html-s found, and transformed for the new directory structure

There is no need to modify the nf-core project (or the runtime)

@refactorTractor refactorTractor changed the title I18n application adapter nf: Angular I18n support Feb 1, 2024
@refactorTractor refactorTractor mentioned this pull request Feb 1, 2024
Open
refactorTractor and others added 26 commits February 2, 2024 09:27
@refactorTractor
feat(i18n): ng adapter writes files, maps exposed files, registers 4 …
b085958 
…rebuild
@refactorTractor
feat(i18n): update all index.html-s
cba5171
@refactorTractor
feat(i18n): preparing bundle, correct external handling
d8af33d
@refactorTractor
beautify: whitespaces
83281e7
@refactorTractor
feat(i18n) fixing up mistakes, whitespaces w/out package changes
1383f6e
@refactorTractor
stylistic changes
1234e24
@refactorTractor
feat(i18n): fix serving locale root
ba042a2
@refactorTractor
feat(i18n): fix finding and writing locales, fix hash handling, inden…
52402e6 
…tations
@refactorTractor
feat(i18n): no polyfills from middleware, put vite entries in remoteE…
f7f7a49 
…ntry direct, filter polyfills for index.html
@refactorTractor
feat(i18n): stylistic changes
ca71726
@refactorTractor
feat(i18n): add localize package, stylistic changes
958492b
@refactorTractor
feat(i18n): stylistic changes
bba5054
@refactorTractor
feat(i18n): should still work without localization
03544d5
@refactorTractor
feat(i18n): NG0203 comes if ng version < 17.1.0
62eaf63
@refactorTractor
feat(i18n): stylistic changes
8f1123f
@refactorTractor
Merge branch 'main' into i18n_application_adapter
38cec49
@refactorTractor
version 17.1.7: rename, fill out new repo data, schematics refer to s…
e0d595d 
…elf not upstream
@refactorTractor
fixes
f27b258
@refactorTractor
change package name
8c7abc7
@refactorTractor
make remoteEntry outside language bundles reference the languages to …
5869851 
…avoid import mapping problems + formatting
@refactorTractor
added pathmappings
fc6d08f
@refactorTractor
prepare schematic to work as a fork. + whitespace formatting
cd39f77
@refactorTractor
fixes
cb01557
@refactorTractor
make remoteEntry outside language bundles reference the languages to …
d93331e 
…avoid import mapping problems
@refactorTractor
added pathmappings
2a64fdb
@refactorTractor
Merge branch 'i18n_support' into i18n_application_adapter
868bc4c
@refactorTractor
Copy link
Author

I will use another branch for merging to this repo

@refactorTractor refactorTractor deleted the i18n_application_adapter branch August 23, 2024 09:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Native federation: support Angular i18n (partially)
1 participant
@refactorTractor